Release v40.2.0 #1662
Release v40.2.0 #1662
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request constitutes a new release, version Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library version to 40.1.1. The version number has been consistently updated across pom.xml, README.md, VERSION, and Client.java. While the changes are correct for the release, I've added a suggestion to improve maintainability by dynamically loading the version in the Java code instead of hardcoding it. This will prevent potential inconsistencies in future releases.
src/main/java/com/adyen/Client.java
Outdated
| private Config config; | ||
| public static final String LIB_NAME = "adyen-java-api-library"; | ||
| public static final String LIB_VERSION = "40.1.0"; | ||
| public static final String LIB_VERSION = "40.1.1"; |
There was a problem hiding this comment.
Hardcoding the library version is prone to errors during releases, as it requires manual updates. To improve maintainability, the version can be loaded dynamically from the JAR's manifest file at runtime. The manifest is automatically populated by Maven during the build with the version from pom.xml, ensuring LIB_VERSION is always accurate and in sync.
public static final String LIB_VERSION;
static {
String version = Client.class.getPackage().getImplementationVersion();
LIB_VERSION = (version != null) ? version : "UNKNOWN";
}
AdyenAutomationBot
force-pushed
the
promote/main
branch
5 times, most recently
from
b200dd5 to
885ca3a
Compare
AdyenAutomationBot
force-pushed
the
promote/main
branch
from
885ca3a to
c63dafb
Compare
Merged pull requests to be released:
Full Changelog: v40.1.0...main